SYSTEM WARNING: 'date_default_timezone_get(): It is not safe to rely on the system's timezone settings. You are *required* to use the date.timezone setting or the date_default_timezone_set() function. In case you used any of those methods and you are still getting this warning, you most likely misspelled the timezone identifier. We selected the timezone 'UTC' for now, but please set date.timezone to select your timezone.' in '/usr/share/mantis/www/core.php' line 264
|Anonymous | Login||2019-08-19 21:03 UTC|
|Main | My View | View Issues | Change Log | Roadmap|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0002422||Endian Firewall||Other Services||public||2009-11-18 20:45||2010-09-24 16:31|
|Priority||normal||Severity||feature||Reproducibility||have not tried|
|Target Version||2.5||Fixed in Version|
|Summary||0002422: make emi modules reloadable|
|Description||with commands.emi.reload all modules will be reloaded, since the cherrypy instance will be re-instantiated completely|
That's ok in some cases, but not ok when you want to do something like this:
emicommand commands.migration.run --pkg=qos
which will be done in %post hook for the efw-qos package for example.
Now, we could also remove all cherrypy references to an emi controller, remove the modules from modules registry, re-import and re-init the emi module. That would be the ideal, because after an upgrade only that proper module will be reloaded.
This can be done by the following code examples:
for i in filter(lambda x: x.startswith("endian.qos"), sys.modules.keys()):
So far so good..
Not every EMI module is reloadable so far. hotspot for example tries to re-register the model and qos tries to re-register datasource filetypes.
So we need to check that every emi module is reloadable.
That means we need to do:
- registries should replace same items and not raise an error (datasource)
- module reload probably need to close also the corresponding database hub,
since reload will reopen it and thus register already registered classes.
- registering modules need to become more intelligent and store for every child
which have been connected its parent-node module string in a searchable
structure. not every controller is connected to manage, so we can't
remove it if we don't find it.
- removing controller need also to remove command and event registrations and
subscriptions. They will however be overwritten, but if a module has an error
during reload or will be removed, those registrations will not be
- removing modules should be generic, in order to be able to do that also on
%postun hook, when an emi module passes by.
- installing modules could also become dynamic in order to be able to call
from emicommand, so installations of new modules do not require an emi restart
hope that's all.
|Tags||No tags attached.|
EMI could store persistently of the version of every module of which that module has been loaded last time.
with this information EMI can understand during module loading (reload/restart) which module needs to restart its services and restart or enqueue them to be scheduled for restart.
this way we don't need to hook those restarts anymore within rpm %post hooks, since every EMI module hooks reload of itself.
after talk with andrea we concluded that it is better to implement lazy loading of the EMI modules and completely destroy all turbogears objects whenever EMI get a SIGHUP. This then can be done on every module update.
So, next access to the module will reload it then
This is way easier to implement and causes few hassles for sure, since that's how cherrypy implements auto-reload of python modules. When it is working ok for cherrypy, it should also for EMI.
|2009-11-18 20:45||peter-endian||New Issue|
|2009-11-18 20:45||peter-endian||Assigned To||=> peter-endian|
|2009-12-01 21:40||peter-endian||Note Added: 0003489|
|2010-02-25 10:50||peter-endian||Note Added: 0003860|
|2010-03-08 19:56||peter-endian||Status||new => confirmed|
|2010-09-24 16:31||peter-endian||Status||confirmed => assigned|
|2010-09-24 16:31||peter-endian||Target Version||2.4 => 2.5|
|Copyright © 2000 - 2012 MantisBT Group|